loadin icon go on display while an error is raised

while downloading data with 'symlink', even if an error is raised the message is not displayed and the user has to wait :

changed milestone to %V3.2.4

added Bug label

assigned to @gsalin

assigned to @rtherville and unassigned @gsalin

There are "validate_field" callbacks on the username and user_directory inputs, but none on the password input. When every parameter has been input and the "start" button has been pressed, a "validate_workflow" callback is called (with every parameter needed for the check).

We could had a check for the password in one of those two callback functions.

The tx_nG6_pi5.js script doesn't handle the statusdata.status beeing "failed" on line 165:

if (statusdata.status == "completed"){
[...]
}
else {
$('#wfstatus').wfstatus('reload');
button.disabled = false;
}

An else if case should be added (line 186) to handle this status:

if (statusdata.status == "completed"){
[...]
}
else if (statusdata.status == "failed") {
    modal.$body.html([
        '<div class="alert alert-danger">',
    	'    <p>The workflow has failed, the password may be incorrect. </p>',
    	'</div>',
    ].join(''));
}
else {
    $('#wfstatus').wfstatus('reload');
    button.disabled = false;
}

mentioned in commit ec67609f

mentioned in merge request !29 (closed)

Sometimes (I don't know why) the statusdata.status stays "started" a long time, resulting in the (seemingly) infinite loading.

This doesn't happend when the user/password are correct ( statusdata.status = "completed"), so I have added this check:

else if (statusdata.status == "failed" || statusdata.status == "started") {
						modal.$body.html([
    	                    '<div class="alert alert-danger">',
    	                    '    <p>The workflow has failed, either the login or password is incorrect. </p>',
                            '    <p>The user must have access to the Genotoul infrastructure. </p>',
    	                    '</div>',
    	                ].join(''));

added Todo label

changed milestone to %V3.2.5

I have changed the message from "The user must have access to the Genotoul infrastructure." to "You must provide the credentials you use to connect to the GenoToul bioinformatics infrastructure."

/ui/nG6/res/js/tx_nG6_pi5.js (line 189)

closed